Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLE15-SP5] Fixed reusing old repositories with new URL #191

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented Oct 27, 2023

Problem

This is the dialog which allows reusing the old reposiotories, possibly with a new URL. The YaST repository was switched to reuse with the new SP5 URL:
sle_upgrade_repo_selection

That actually works fine, but when the user goes back in the workflow and then forth then this dialog was skipped and the old repository was reused with the old URL. That could cause some dependency issues.

After going back and forth you can see the old SP4 URL and the old 4.4.x package version in the details:
sle_upgrade_broken_after_going_back

Solution

It turned out that the previously used repositories were not dropped early enough so the selection dialog was skipped and the old repository was used.

Testing

  • Tested manually in
    • DVD medium based (offline) upgrade to SLE-15-SP5
    • SCC (online) upgrade to SLE-15-SP5
    • Medium based upgrade to Leap 15.5
  • Going back and forth was fixed in SLE, but the problem remains in Leap. On the other hand it was completely broken there even without going back, now it at least works without going back so it is still better than it was. Fixing Leap is not trivial and I do not want to waste time here...

With the fix you can see the new SP5 URL and correct 4.5.x package version even after going back and forth:
sles_upgrade_fixed

@coveralls
Copy link

Coverage Status

coverage: 31.422% (+0.02%) from 31.405% when pulling f2bd556 on sp5_fix_going_back into d23d9c8 on SLE-15-SP5.

@lslezak lslezak merged commit f961b65 into SLE-15-SP5 Oct 30, 2023
12 checks passed
@lslezak lslezak deleted the sp5_fix_going_back branch October 30, 2023 15:52
@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #748 successfully finished
✔️ Created IBS submit request #311841

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants